Changes for page Peer reviews
Last modified by Danniar Firdausy on 2024/09/18 14:42
From version 18.1
edited by Erik Bakker
on 2022/08/30 08:27
on 2022/08/30 08:27
Change comment:
There is no comment for this version
Summary
-
Page properties (2 modified, 0 added, 0 removed)
Details
- Page properties
-
- Author
-
... ... @@ -1,1 +1,1 @@ 1 -XWiki.e bakker1 +XWiki.eMagiz - Content
-
... ... @@ -3,6 +3,9 @@ 3 3 4 4 Should you have any questions, please contact [[academy@emagiz.com>>mailto:academy@emagiz.com]]. 5 5 6 +* Last update: April 22nd, 2021 7 +* Required reading time: 8 minutes 8 + 6 6 == 1. Prerequisites == 7 7 8 8 * Basic knowledge of the eMagiz platform ... ... @@ -22,6 +22,8 @@ 22 22 * Architecture challenge and verification 23 23 * Find alternative solutions 24 24 28 + 29 + 25 25 == 3. Running peer reviews in eMagiz == 26 26 27 27 === 3.1 Considerations for reviewee === ... ... @@ -31,8 +31,8 @@ 31 31 * Quickly explain the story / task / background 32 32 * Quickly show the working result if applicable / practical 33 33 * Talk through the solution while showing the models / code 34 - * *Just trying to explain your work to someone else will help spot mistakes35 - * *Don’t show every single detail but try to highlight the important parts and/or details you’re less sure about. This takes time and experience to get “right” and is different depending on the story, the reviewee, the reviewer, the project, etc.39 + * Just trying to explain your work to someone else will help spot mistakes 40 + * Don’t show every single detail but try to highlight the important parts and/or details you’re less sure about. This takes time and experience to get “right” and is different depending on the story, the reviewee, the reviewer, the project, etc. 36 36 * Always do a peer review, no exceptions. Making assumptions about the usefulness beforehand defeats the whole purpose. 37 37 38 38 === 3.2 Considerations for reviewer === ... ... @@ -40,52 +40,54 @@ 40 40 Here are some things to keep in mind when peer reviewing the work . 41 41 42 42 * Ask questions 43 - * *How does this work?44 - * *Why did you decide to …?45 - * *Did you think about …?48 + * How does this work? 49 + * Why did you decide to …? 50 + * Did you think about …? 46 46 * Spot (incorrect) assumptions 47 47 * Check application of best practices – see next slide 48 - * *Modelling / coding patterns49 - * *Naming conventions50 - * *Errors / warnings53 + * Modelling / coding patterns 54 + * Naming conventions 55 + * Errors / warnings 51 51 * Notice non-standard / unusual / abnormal things 52 - * *Make sure this is documented, mainly for future changes. Annotations are very useful here.57 + * Make sure this is documented, mainly for future changes. Annotations are very useful here. 53 53 54 54 === 3.3 Peer review items per ILM Phase === 55 55 56 56 * Capture 57 - * *100% filled58 - * *Connection method clear59 - * *Authentication method clear60 - * *Definitions loaded61 - * *Sizing impact understood and valid62 + * 100% filled 63 + * Connection method clear 64 + * Authentication method clear 65 + * Definitions loaded 66 + * Sizing impact understood and valid 62 62 * Design 63 - * *Check solution architecture validity64 - * *Design 100% filled and clear65 - * *CDM Root entity mapped66 - * *Set as mapped – avoid line mapping67 - * *Use annotation where possible68 - * *Proper flow and system settings68 + * Check solution architecture validity 69 + * Design 100% filled and clear 70 + * CDM Root entity mapped 71 + * Set as mapped – avoid line mapping 72 + * Use annotation where possible 73 + * Proper flow and system settings 69 69 * Create 70 - * *Validate routing71 - * *Generic error response flows72 - * *Check naming conventions flows, properties and XSD73 - * *Split messages in on-ramp – not later75 + * Validate routing 76 + * Generic error response flows 77 + * Check naming conventions flows, properties and XSD 78 + * Split messages in on-ramp – not later 74 74 * Deploy 75 - * *Check properties76 - * *Avoid too many different flow versions – max. 277 - * *Remove test packages that are deployed80 + * Check properties 81 + * Avoid too many different flow versions – max. 2 82 + * Remove test packages that are deployed 78 78 * Manage 79 - * *All alerts mapped to Customer Support80 - * *All messages can be explained81 - * *Avoid code mappings82 - * *Enable default alerts84 + * All alerts mapped to Customer Support 85 + * All messages can be explained 86 + * Avoid code mappings 87 + * Enable default alerts 83 83 * Architecture 84 - * *Deploy connector close to the source/target system85 - * *Ensure ACCP and PROD are exact copies86 - * *Cloud over on-premise87 - * *No hard-coded variable – use properties89 + * Deploy connector close to the source/target system 90 + * Ensure ACCP and PROD are exact copies 91 + * Cloud over on-premise 92 + * No hard-coded variable – use properties 88 88 94 + 95 + 89 89 == 4. Assignment == 90 90 91 91 See how peer reviews are currently implemented within the projects on which you work to see if you can learn something from the information you have gathered via this microlearning. ... ... @@ -94,6 +94,8 @@ 94 94 95 95 Peer reviews are instrumental in any DevOps team. Use the provided list as your team's peer review starting point and tune as you go along. 96 96 104 + 105 + 97 97 == 6. Suggested Additional Readings == 98 98 99 99 You will find plenty background items available on the Internet. ... ... @@ -100,4 +100,6 @@ 100 100 101 101 == 7. Silent demonstration video == 102 102 103 -As this is a more theoretical microlearning we have no video for this.)))((({{toc/}}))){{/container}}{{/container}} 112 +As this is a more theoretical microlearning we have no video for this. 113 + 114 +)))((({{toc/}}))){{/container}}{{/container}}